Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(measurement): fix for measurement jump is not switching series in 2DMPR #4779

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(measurement): fix for measurement jump is not switching series in 2DMPR #4779

wants to merge 6 commits into from

Conversation

arul-trenser
Copy link
Contributor

@arul-trenser arul-trenser commented Feb 12, 2025 •
edited
Loading

Context

slice-jump-on-series-switch-issue.mp4

Changes & Results

on common layout while clicking on tracked measurement of different series, the viewport will update the series for the measurement but the jump to slice is not working

_checkForCachedJumpToMeasurementEvents function has been called, if we have measurement during loadViewportData.

fix-measurement-jump.mp4

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 18.19.0
  • Browser: Chrome 131.0.6778.265

@netlify Netlify
Copy link

netlify bot commented Feb 12, 2025 •
edited
Loading

✅ Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 233a0df
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/67be9b6e876b3a000863c87d

@netlify Netlify
Copy link

netlify bot commented Feb 12, 2025 •
edited
Loading

✅ Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 233a0df
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/67be9b6e309d340008ad1c9b

@arul-trenser arul-trenser marked this pull request as draft February 12, 2025 09:19
@arul-trenser arul-trenser marked this pull request as ready for review February 13, 2025 03:58
@sedghi
Copy link
Member

sedghi commented Feb 18, 2025

I'm not able to reproduce the bug in our master branch, are you sure it is happening here https://viewer-dev.ohif.org/viewer?StudyInstanceUIDs=1.2.840.113619.2.290.3.3767434740.226.1600859119.501

@arul-trenser
Copy link
Contributor Author

@sedghi We are still able to reproduce the issues in https://viewer-dev.ohif.org/ .

on common layout while clicking on tracked measurement of different series, the viewport will update the series for the measurement but the jump to slice is not working.

Previous in v3.8, while clicking on measurement in measurement panel, the viewport will load corresponding series and navigates to corresponding slice.
Currently in master and in v3.9, while clicking on measurement in panel, on first click the viewport is loaded with corresponding series and on second click the navigation to corresponding slice is happening.

slice-jump-on-series-change-issue.mp4

Issue 2: #4751 is also reproduceable in current main.

mpr-mode-jump-to-series-issues.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedghi sedghi sedghi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Measurement Selection Not Switching Series in 2D MPR View
2 participants
@arul-trenser @sedghi